Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitivity analysis var name #300

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

marjanfamili
Copy link
Collaborator

This PR addresses #279

problem which includes the variable name
and the variable value to the sensitivity analysis
Comment on lines 180 to 183
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blackfmt] reported by reviewdog 🐶

Suggested change
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}

Comment on lines 191 to 194
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[blackfmt] reported by reviewdog 🐶

Suggested change
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}
"num_vars": 2,
"names": ["c", "v0"],
"bounds": [(-5.0, 1.0), (0.0, 1000.0)],
}

Copy link
Contributor

github-actions bot commented Feb 17, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  autoemulate
  sensitivity_analysis.py 273
  autoemulate/emulators
  gaussian_process.py
  tests
  test_sensitivity_analysis.py
Project Total  

This report was generated by python-coverage-comment-action

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.24%. Comparing base (005b3c0) to head (9359041).
Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
autoemulate/sensitivity_analysis.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   94.17%   94.24%   +0.07%     
==========================================
  Files          62       65       +3     
  Lines        3606     3755     +149     
==========================================
+ Hits         3396     3539     +143     
- Misses        210      216       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sgreenbury
Copy link
Collaborator

Thanks @marjanfamili, this looks great - I left two related suggestions above in the code.

@radka-j
Copy link
Member

radka-j commented Feb 24, 2025

@all-contributors add @sgreenbury for code, ideas, review, projectManagement

Copy link
Contributor

@radka-j

I've put up a pull request to add @sgreenbury! 🎉

Use SALib ResultDict.to_df() function to provide results in pandas dataframe format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants